this post was submitted on 28 Sep 2023
4 points (100.0% liked)

Games

32506 readers
1541 users here now

Welcome to the largest gaming community on Lemmy! Discussion for all kinds of games. Video games, tabletop games, card games etc.

Weekly Threads:

What Are You Playing?

The Weekly Discussion Topic

Rules:

  1. Submissions have to be related to games

  2. No bigotry or harassment, be civil

  3. No excessive self-promotion

  4. Stay on-topic; no memes, funny videos, giveaways, reposts, or low-effort posts

  5. Mark Spoilers and NSFW

  6. No linking to piracy

More information about the community rules can be found here.

founded 1 year ago
MODERATORS
 

Larion Studios forum stores your passwords in unhashed plaintext. Don't use a password there that you've used anywhere else.

you are viewing a single comment's thread
view the rest of the comments
[–] [email protected] 0 points 1 year ago (1 children)

That's very unlikely. It's running UBB Threads, which, from what I can tell, has an auth subsystem, which au minimum would do hashing. If it's providing you with a default at sign-up, that's different and is what appears to be a configurable setting.

If it is completely generated for you, here's what probably happening:

  1. User creation module runs a password generator and stores this and the username in memory as string variables.
  2. User creation module calls back to storage module to store new user data in db, including the value of the generated password var.
  3. Either the storage module or another middleware module hashes the password while preparing to store.
  4. Storage module reports success to user creation.
  5. User creation module prints the vars to the welcome template and unloads them from memory.

TL;DR as this is running on a long-established commercial php forum package, with DB storage, it is incredibly unlikely that the password is stored in the DB as plaintext. At most it is likely stored in memory during creation. I cannot confirm, however, as it is not FOSS.

[–] [email protected] 0 points 1 year ago (1 children)

It sends the user generated password, not an auto generated one.

[–] [email protected] 0 points 1 year ago (1 children)

Yeah if they send the password in an email in plain text that's not storing it. You can send the email before you store the password while it's still in memory and then hash it and store it.

[–] [email protected] -1 points 1 year ago* (last edited 1 year ago) (1 children)

Stored in memory is still stored. It's still unencrypted during data processing. Still bad practice and a security vulnerability at best. Email isn't E2E encrypted.

[–] [email protected] 0 points 1 year ago (1 children)

Stored in memory is still stored.

Given what I know about how computers accept user input, I am fascinated to hear what the alternative is.

[–] [email protected] -1 points 1 year ago* (last edited 1 year ago) (1 children)

You have the text input feed directly into the encryption layer without an intermediary variable. The plaintext data should never be passable to an accessible variable which it must be to send the plaintext password in the email because it's not an asynchronous process.

I'm surprised so many people are getting hung up on basic infosec.

[–] [email protected] 0 points 1 year ago (1 children)

Are you suggesting to do all this on the frontend before it goes to the backend?

[–] [email protected] -1 points 1 year ago* (last edited 1 year ago) (3 children)

The front end to backend traffic should be encrypted, hashing occurs on the backend. The backend should never have access to a variable with a plaintext password.

I'm going to have to stop replying because I don't have the time to run every individual through infosec 101.

[–] [email protected] 0 points 1 year ago (1 children)

I’m going to have to stop replying because I don’t have the time to run every individual through infosec 101.

Sorry, but you're missing the point here. You cannot do anything with a password without storing it in memory. That's not even infosec 101, that's computing 101. Every computation is toggling bits between 1 and 0 and guess where these bits are stored? That's right: in memory.

The backend should never have access to a variable with a plaintext password.

You know how the backend gets that password? In a plaintext variable. Because the server needs to decrypt the TLS data before doing any computations on it (and yes I know about homomorphic encryption, but no that wouldn't work here).

Yes, I agree it's terrible form to send out plain text passwords. And it would make me question their security practices as well. I agree that lots of people overreacted to your mistake, but this thread has proven that you're not yet as knowledgeable as you claim to be.

[–] [email protected] -1 points 1 year ago* (last edited 1 year ago)

You encrypt the datastream from the text input on the client side before storing it in a variable. It's not rocket science. I did this shit 20 years ago. Letting a plaintext password leave the user client is fucking stupid.

[–] [email protected] 0 points 1 year ago (1 children)

I asked because what you're describing doesn't do much if you understand how common web frameworks and runtime environments work.

The framework needs to parse the HTTP request. That means holding the parameters in a variable somewhere just to arrange them in a datastructure for processing.

But let's ignore that and say we have some kind of system that stream parses the request right out of the buffer (which itself still needs to be held in memory for a bit, but let's ignore that), and when it matches a preconfigured password parameter, passes it directly to the hashing system and nowhere else. I don't think any framework in existence actually does this, but let's run with it.

We'll still need to pass that value by whatever the language uses for function passing. It will be in a variable at some point. Since we rarely write in C these days unless we have to, the variable doesn't go away in the system until the garbage collection runs. Most systems don't use ref counting (and I think it's a mistake to disregard the simplicity of ref counting so universally, but that's another discussion), so that could happen whenever the thread gets around to it.

But even if it runs in a timely fashion, the memory page now has to be released to the OS. Except most runtimes don't. First, the variable in question almost certainly was not the only thing on that page. Second, runtimes rarely, if ever, release pages back to the OS. They figure if you're using that much memory once, you'll probably do it again. Why waste time releasing a page just to make you spend more time getting it again?

And we're still not done. Let's say we do release the page. The OS doesn't zero it out. That old variable is still there, and it could be handed over to a completely different process. Due to Copy on Write, it won't be cleared until that other process tries to write it. In other words, it could still be read by some random process on the system.

And we haven't even mentioned what happens if we start swapping. IIRC, some Linux kernel versions in the 2.4 series decided to swap out to disk ahead of time, always having a copy of memory on disk. Even if you're not running such an ancient version, you have to consider that the kernel could do as it pleases. Yeah, now that var potentially has a long lifespan.

To do what you want, we would need to coordinate clearing the var from the code down through the framework, runtime, and kernel. All to protect against a hypothetical memory attack. Which are actually quite difficult to pull off in practice. It'd be easier to attack the client's machine in some way.

And on top of it, you're running around with an undeserved sense of superiority while it's clear you haven't actually thought this through.

[–] [email protected] -1 points 1 year ago (1 children)

Yes. I agree 100% with the things I can and I defer to your experience where I can't. I used to write proprietary networking protocols 20 years ago and that's the knowledge and experience I'm leaning on.

As a matter of practice we would ensure to process passwords by encrypting the datasteam directly from the input, and they were never unencrypted in handling, so as to protect against various system and browser vulnerabilities. It would be a big deal to have them accessible in plaintext beyond the user client, not to mention accessible and processable by email generation methods and insecure email protocols.

[–] [email protected] 0 points 1 year ago (1 children)
[–] [email protected] -1 points 1 year ago

It's a good thing your opinion makes no difference then isn't it.

[–] [email protected] 0 points 1 year ago* (last edited 1 year ago) (1 children)

how long have you been a web developer? Because I've been doing it for six years and almost every web app I've ever seen uses http with TLS to send the plaintext password to the backend, where it's popped into a request var at the controller level, then passed as an instance var to the service level, salted, hashed and stored. This includes apps that have to submit themselves for HIPAA compliance because they deal with PHI.

[–] [email protected] -1 points 1 year ago

25, I used to write proprietary networking protocols.