this post was submitted on 16 Nov 2023
2 points (100.0% liked)

Programmer Humor

19187 readers
1102 users here now

Welcome to Programmer Humor!

This is a place where you can post jokes, memes, humor, etc. related to programming!

For sharing awful code theres also Programming Horror.

Rules

founded 1 year ago
MODERATORS
 
top 9 comments
sorted by: hot top controversial new old
[–] [email protected] 1 points 10 months ago (1 children)

The worst case is when someone requires changes, you address them, but then they disappear/go on a leave.

If the repository rules require all conversations to be resolved before merging and only the original reviewer can mark them as solved, the PR is stuck forever even if the rest of the team approves it.

[–] [email protected] 1 points 10 months ago (1 children)

That sounds like something you bring up in the retro

[–] [email protected] 0 points 10 months ago (1 children)

When the person came back from the leave I made some passive aggressive remark, hope this is enough 🤣

[–] [email protected] 0 points 10 months ago

Have you tried ignoring their PRs for a few weeks?

[–] [email protected] 1 points 10 months ago

A 15000 line PR landing on a Friday evening for the lucky random reviewer to open on Monday. "Please approve it fast so we avoid too many conflicts."

[–] [email protected] 0 points 10 months ago (1 children)

Also me waiting for the junior dev to address review comments satisfactorily.

[–] [email protected] 0 points 10 months ago

It's a game where they try to make you impatient enough that you do it for them.

[–] [email protected] 1 points 10 months ago* (last edited 10 months ago)

Yeah, this is my colleagues waiting for me, poor bastards

[–] [email protected] 1 points 10 months ago

This always happens to me when I’ve written some genius code. Takes so long to review it, because my caveman colleagues don’t understand it.