Programmer Humor

19537 readers

523 users here now

Welcome to Programmer Humor!

This is a place where you can post jokes, memes, humor, etc. related to programming!

For sharing awful code theres also Programming Horror.

Rules

Keep content in english
No advertisements
Posts must be related to programming or programmer topics

founded 1 year ago

MODERATORS

[email protected]

976

Review Please (programming.dev)

submitted 7 months ago by [email protected] to c/[email protected]

112 comments fedilink hide all child comments

you are viewing a single comment's thread
view the rest of the comments

[–] [email protected] 8 points 7 months ago (7 children)

I try to keep my changes under 300-350 lines. Seems like a good threshold.

I'm still annoyed that Github doesn't have good support for stacked diffs. It's still not possible to say that one PR depends on a different one, and still has no ability to review and land them as a stack.

[–] [email protected] 6 points 7 months ago (6 children)

How is this different from creating a feature branch and making your PR against them until everything is done, then merging that into the main branch?

[–] [email protected] 1 points 7 months ago

also iirc gitlab does offer something like this as a feature now with "merge trains" (though i've never really used it, usualy just go for the feature branch out of habit x) )

load more comments (5 replies)