this post was submitted on 25 Feb 2024
962 points (98.1% liked)
Programmer Humor
32490 readers
541 users here now
Post funny things about programming here! (Or just rant about your favourite programming language.)
Rules:
- Posts must be relevant to programming, programmers, or computer science.
- No NSFW content.
- Jokes must be in good taste. No hate speech, bigotry, etc.
founded 5 years ago
MODERATORS
you are viewing a single comment's thread
view the rest of the comments
view the rest of the comments
At my workplace, we have a lint rule that reports an error if
@nocommitis anywhere in the file, plus a commit hook that blocks all commits with@nocommitanywhere in them. It works well and has saved me a few times.Works pretty well, except the lint rule and its associated tests have to do something like
"@no"+"commit"to avoid triggering it,In a lot of modern work flows this is incompatible with the development pattern.
For example, at my job we have to roll a test release through CI that we then have to deploy to a test kubernetes cluster. You can't even do that if the build is failing because of linting issues.
The test release shouldn't have anything marked with
@nocommitthough... The idea is that you use it to mark code that is only temporary local debugging code that should never be committed.Are you committing to
master? I don't see any reason why you shouldn't commit your debugging code to your own branch. Obviously clean it up before mergingMy workplace uses feature flags rather than feature branches, and a continuous deployment cycle, so we only have one branch.
I did the same thing with "DO NOT MERGE" back in the day. Saved some people who didn't even know about the check.