this post was submitted on 28 Feb 2024
1466 points (99.7% liked)

Programmer Humor

32266 readers
60 users here now

Post funny things about programming here! (Or just rant about your favourite programming language.)

Rules:

founded 5 years ago
MODERATORS
 
you are viewing a single comment's thread
view the rest of the comments
[–] [email protected] 97 points 7 months ago (10 children)

We decided that everyone in the team is allowed to approve changes. If no one has reviewed your change within 24 hours you are allowed to approve it yourself. It will usually come up in the daily sync that a self approval is imminent, which usually leads to someone taking a look.

[–] [email protected] 27 points 7 months ago (3 children)
[–] [email protected] 43 points 7 months ago (2 children)

Surely this will just devolve into "no reviews ever".

[–] [email protected] 5 points 7 months ago* (last edited 7 months ago)

We very seldom resort to self approvals. Everyone in the team see code reviews as important. But also that progress trumps code review.

load more comments (1 replies)
load more comments (1 replies)
load more comments (7 replies)